Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump tsx #498

Merged
merged 3 commits into from
Oct 23, 2023
Merged

Bump tsx #498

merged 3 commits into from
Oct 23, 2023

Conversation

xHomu
Copy link
Contributor

@xHomu xHomu commented Oct 23, 2023

Get rid of the --experimental-loader warning from node when using tsx:

image

See privatenumber/tsx#330

Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, thanks!

@kentcdodds
Copy link
Member

Looks like we need the lockfile to be updated.

@xHomu
Copy link
Contributor Author

xHomu commented Oct 23, 2023

Ah, good catch.

Is there any reason why we're keeping node engine at 18?

@xHomu
Copy link
Contributor Author

xHomu commented Oct 23, 2023

I see, weird:

image

Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kentcdodds kentcdodds merged commit e066662 into epicweb-dev:main Oct 23, 2023
5 checks passed
@xHomu xHomu deleted the patch-1 branch October 23, 2023 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants