-
Notifications
You must be signed in to change notification settings - Fork 424
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added basic prometheus implementation #503
Added basic prometheus implementation #503
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! This is a great start! I have a few comments. Also, would you mind adding a new docs markdown file for this?
Awesome, I resolved all the comments but I'm having an issue with the playwright run. I'll have more time this week to look at it, but if anyone wanted to take a look in the mean time. I'm fairly certain the issue revolves around how the server-build is importing the TS version of the prometheus.server.ts, in the JS file built file its trying to import I will for sure work on getting some kind of docs updated too. |
Sorry about that! I think this should work :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I addressed all changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is super! Just a couple last things to tidy up and we're good to go. Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, just realized one more thing
Hey @swalker326, I just had a conversation with Milin (the CEO of Sentry) on something unrelated to this. But then this effort came up and Milin told me that Sentry has a lot of really awesome features that we can use to accomplish the same thing but better. I hope you don't mind if I pump the breaks on this until I can meet up with someone else from Sentry to evaluate what their offering is. I always hate doing this kind of thing because I know you and @matt-winfield put a lot of effort into contributing these improvements to the stack. I hope you understand as we work hard to come up with the very best solution for everyone. |
Excited to hear about what Sentry can bring to this area! More options are always a good thing. And I just like to share the things I was going to be investigating anyway, hearing about cool alternatives is one of the main benefits - doesn't really matter to me if my original idea ends up being included 🙂 |
I share the same sentiment as @matt-winfield. No worries here at all, was fun to dig into it. |
Would @matt-winfield @swalker326 mind sharing the grafana dashboard which uses these metrics please? |
Now that sentry is well supported,I think we can choose this |
Thanks so much for the work on it though! |
Added base prometheus implementation to track metrics.
Test Plan
navigate to
localhost:9091/metrics
to see query events being tracksChecklist
Screenshots