Fix/#638 #837
Merged
Fix/#638 #837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #638 and #690 by "gracefully" handling errors in getBuild()
might make sense to do this for serverBuild too but it seems to work without
Explanation
When an import error occurs, the express server, for whatever reason, seems to crash unrecoverably.
You can check this by running
sudo lsof -i -P -n | grep LISTENafter an import error has occurred, the server should not be running on your chosen port anymore.I am not sure why before this PR the error is not caught though and displayed correctly because express has a default error handler that should prevent this from happening. In any case, this PR fixes this issue whatever the underlying reason might be.