Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename tolerance #714

Closed
sbfnk opened this issue Jul 11, 2024 · 0 comments · Fixed by #734
Closed

rename tolerance #714

sbfnk opened this issue Jul 11, 2024 · 0 comments · Fixed by #734
Assignees

Comments

@sbfnk
Copy link
Contributor

sbfnk commented Jul 11, 2024

The tolerance argument for dist_spec objects and the apply_tolerance function don't have a self-explanatory name (it was inherited from the previous convolution function where it perhaps made more sense).

I'd suggest something like cdf_cutoff and make it 1-tolerance, i.e. setting it to 0.999 means cutting the CDF at 0.999.

@sbfnk sbfnk self-assigned this Aug 1, 2024
@sbfnk sbfnk added this to the CRAN v1.6 release milestone Aug 1, 2024
@sbfnk sbfnk mentioned this issue Aug 2, 2024
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant