Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tolerance -> cdf_cutoff #734

Merged
merged 12 commits into from
Sep 20, 2024
Merged

tolerance -> cdf_cutoff #734

merged 12 commits into from
Sep 20, 2024

Conversation

sbfnk
Copy link
Contributor

@sbfnk sbfnk commented Aug 2, 2024 •
edited
Loading

Description

This PR closes #714.

Initial submission checklist

  • My PR is based on a package issue and I have explicitly linked it.
  • I have tested my changes locally (using devtools::test() and devtools::check()).
  • I have added or updated unit tests where necessary.
  • I have updated the documentation if required and rebuilt docs if yes (using devtools::document()).
  • I have followed the established coding standards (and checked using lintr::lint_package()).
  • I have added edited a news item linked to this PR. (as change to development version)

After the initial Pull Request

  • I have reviewed Checks for this PR and addressed any issues as far as I am able.

@sbfnk sbfnk marked this pull request as draft August 2, 2024 13:28
@sbfnk
Copy link
Contributor Author

sbfnk commented Sep 20, 2024

Testing this uncovered some other small required changes that have been added here.

@sbfnk sbfnk marked this pull request as ready for review September 20, 2024 09:11
seabbs
seabbs approved these changes Sep 20, 2024
View reviewed changes
Copy link
Contributor

@seabbs seabbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sbfnk sbfnk added this pull request to the merge queue Sep 20, 2024
Merged via the queue into main with commit be1c735 Sep 20, 2024
9 checks passed
@sbfnk sbfnk deleted the cdf_cutoff branch September 20, 2024 10:44
jamesmbaazam pushed a commit that referenced this pull request Sep 20, 2024
@sbfnk @jamesmbaazam
tolerance -> cdf_cutoff (#734)
8129ccf 
* tolerance -> cdf_cutoff

* can't set cutoff if distribution is uncertain

* try to discretise for max

* collapse as S3 method

* simplify checks

* replace max call with attribute

* collapse delays

* suppress options

* test more comprehensively

* update docs

* update sparse tail warning

* update documentation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seabbs seabbs seabbs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

rename tolerance
2 participants
@sbfnk @seabbs