Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix logmean bound #435

Merged
merged 2 commits into from
Jul 25, 2023
Merged

fix logmean bound #435

merged 2 commits into from
Jul 25, 2023

Conversation

sbfnk
Copy link
Contributor

@sbfnk sbfnk commented Jul 24, 2023

d0bea23 introduced a bug where the logmean of delays is lower-bounded by 0 whereas it shouldn't be (for the gamma distribution this is done in the delays_lp function).

@github-actions
Copy link
Contributor

This is how benchmark results would change (along with a 95% confidence interval in relative change) if 1023267 is merged into main:

  •   :ballot_box_with_check:default: 1.15m -> 1.08m [-16.44%, +5.5%]
  •   :ballot_box_with_check:no_delays: 1.07m -> 1.02m [-15.61%, +5.26%]
  •   :ballot_box_with_check:random_walk: 21.1s -> 20.1s [-34.67%, +24.78%]
  •   :ballot_box_with_check:stationary: 38.4s -> 39.9s [-9.53%, +17.36%]
  •   :ballot_box_with_check:uncertain: 1.4m -> 1.57m [-8.73%, +32.97%]
    Further explanation regarding interpretation and methodology can be found in the documentation.

@sbfnk
Copy link
Contributor Author

sbfnk commented Jul 24, 2023

No NEWS item needed IMO as no change to previous minor version.

Copy link
Contributor

@seabbs seabbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Good spot.

@seabbs seabbs merged commit b986893 into main Jul 25, 2023
11 checks passed
@seabbs seabbs deleted the fix-mean-bound branch July 25, 2023 12:55
sbfnk added a commit that referenced this pull request May 3, 2024
* fix logmean bound

* increment dev version
sbfnk added a commit that referenced this pull request May 3, 2024
* fix logmean bound

* increment dev version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants