-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switching to broadcasting random walk #747
Conversation
…into broadcast-rw
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This is how benchmark results would change (along with a 95% confidence interval in relative change) if d94e55e is merged into main:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @seabbs. LGTM. Thanks for adding the tests and documentation.
To confirm that I understood everything here. This was more of a refactoring exercise to use more elegant stan tricks right? I noticed most of the right hand side code is a better rewrite of the deleted code using what we would call vectorization in R parlance.
Co-authored-by: James Azam <james.azam@lshtm.ac.uk>
yes and to ideally reduce compilation and run time (which I think it does a tiny bit) |
This is how benchmark results would change (along with a 95% confidence interval in relative change) if 7822fe8 is merged into main:
|
This is how benchmark results would change (along with a 95% confidence interval in relative change) if 8457a9e is merged into main:
|
Description
Following on from #746 this PR switches to broadcasting for the random walk parameterizations. It also adds docs and tests.
Initial submission checklist
devtools::test()
anddevtools::check()
).devtools::document()
).lintr::lint_package()
).After the initial Pull Request