-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace base R message/warning/stop with {cli}
#762
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great. Like the lintr as the package check and the use of colour highlighting. You have some very unhappy CI which I expect is due to error and warning testing needing to be updated.
Sorry, I should have marked this as a draft. Have a few simple fixes then we can try the new changes and see if happy before merging, or we can merge this and apply fancier stuff in another run. {cli} is addictive and I'm trying not to go crazy. |
{cli}
{cli}
Co-authored-by: Sam Abbott <s.e.abbott12@gmail.com>
Ha I know I think this and do fancier stuff in a new PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice. Looks good.
Description
This PR closes #546.
This PR replaces the use of base condition signalling with those provided by
{cli}
as it offers more powerful features such as the ability to display a warning every few hours.As part of this PR, I've updated the
.lintr
config file to catch future uses of base messaging. This was really useful in the refactoring exercise as it caught all occurrences. There were some false positives in theregional_epinow.R
, so I embraced them in#nolint undesirable_function_linter
tags to counter the configs I've set up.Initial submission checklist
devtools::test()
anddevtools::check()
).devtools::document()
).lintr::lint_package()
).After the initial Pull Request