add vignette with theoretical background #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesmbaazam
approved these changes
Aug 8, 2023
There was a problem hiding this comment.
Thanks for adding this vignette. I learned a lot while reviewing it and I think it will be insightful to users/developers seeking to understand the theory behind the functionality provided here.
I made some suggestions, which are mostly a matter of style except the equation for the loglikelihood of the size distribution of a chain with negative binomial offspring, which I think miss-signed one of the terms. I might be wrong, though.
Co-authored-by: James Azam <james.m.azam@gmail.com>
sbfnk
force-pushed
the
theory_vignette
branch
from
bcb6e71
to
5cd7a7d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addresses epiverse-trace/epichains#35 but adding it here first to it can go with the CRAN submission