Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cypress/reviewing menu tests #367

Merged
merged 5 commits into from
Aug 7, 2023
Merged

Cypress/reviewing menu tests #367

merged 5 commits into from
Aug 7, 2023

Conversation

mmartin24
Copy link
Contributor

Stabilizes menu tests.

Done:

  • Adding explicit wait of 10 s before reload. This is done because Cypress did not wait for the previous command to be ended and launched reload almost at the same time. This caused severe problems leaving Cypress hanging for rest of tests at times.
  • Adding implicit waits for elements

Tests done:
https://github.com/epinio/epinio-end-to-end-tests/actions/runs/5753679141
https://github.com/epinio/epinio-end-to-end-tests/actions/runs/5755425779

@mmartin24 mmartin24 self-assigned this Aug 3, 2023
@mmartin24 mmartin24 requested a review from thehejik August 3, 2023 22:22
@thehejik thehejik merged commit ea67a87 into main Aug 7, 2023
@thehejik thehejik deleted the cypress/reviewing-menu-tests branch August 7, 2023 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thehejik thehejik thehejik approved these changes

Assignees

@mmartin24 mmartin24

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mmartin24 @thehejik