Send edit request only if settings change

Signed-off-by: Francesco Torchia <francesco.torchia@suse.com>
epinio · Sep 8, 2023 · 8ef9806 · 8ef9806
1 parent 538c244
commit 8ef9806
Showing 1 changed file with 11 additions and 9 deletions.
diff --git a/dashboard/pkg/epinio/edit/services.vue b/dashboard/pkg/epinio/edit/services.vue
@@ -64,7 +64,7 @@ export default Vue.extend<Data, EpinioCompRecord, EpinioCompRecord, EpinioCompRe
       errors:                          [],
       failedWaitingForServiceInstance: false,
       selectedApps:                    this.value.boundapps || [],
-      chartValues:                     this.value.settings || {},
+      chartValues:                     objValuesToString(this.value.settings) || {},
       validChartValues:                {}
     };
   },
@@ -134,6 +134,13 @@ export default Vue.extend<Data, EpinioCompRecord, EpinioCompRecord, EpinioCompRe
   methods: {
     async save(saveCb: (success: boolean) => void) {
       this.errors = [];
+
+      const newSettings = !isEqual(objValuesToString(this.chartValues), objValuesToString(this.value.settings));
+
+      if (newSettings) {
+        this.value.settings = objValuesToString(this.chartValues);
+      }
+
       try {
         if (this.isCreate) {
           await this.value.create();
@@ -144,7 +151,9 @@ export default Vue.extend<Data, EpinioCompRecord, EpinioCompRecord, EpinioCompRe
         }
 
         if (this.isEdit) {
-          await this.value.update();
+          if (newSettings) {
+            await this.value.update();
+          }
           await this.updateServiceInstanceAppBindings(this.value);
           await this.value.forceFetch();
         }
@@ -165,7 +174,6 @@ export default Vue.extend<Data, EpinioCompRecord, EpinioCompRecord, EpinioCompRe
     },
     resetChartValues() {
       this.chartValues = {};
-      this.value.settings = null;
       this.validChartValues = {};
     }
   },
@@ -174,12 +182,6 @@ export default Vue.extend<Data, EpinioCompRecord, EpinioCompRecord, EpinioCompRe
     'value.meta.namespace'() {
       Vue.set(this, 'selectedApps', []);
     },
-    chartValues: {
-      handler(neu) {
-        this.value.settings = objValuesToString(neu);
-      },
-      deep: true
-    }
   }
 
 });