-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add progress bar when exporting Applications #261
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I couldn't quite get this to work
- The values and chart bars complete almost straight away
- the images chart
- remains on zero for a long time
- We should have some status text before showing the progress bar. that can be replaced when we get the first chunk through
- when we start getting download progress notifications it moves up to 1/3 or a 1/2 then stops
- the network request eventually completes (possibly times out at 2mins)
- nothing else happens (no file download, progress bar stuck
- remains on zero for a long time
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
click away
cancel should cancel requerst
message for compressing files
Things we should capture in another issue / PR
- modal should be block... so if the user accidentally clicks outside of modal they don't lose the last x minutes of progress
minor want, clicking cancel will cancel the http request to fetch the image. not sure if this is possible though
showProgressBar: false, | ||
downloadingPart: null, | ||
progressBar: 0, | ||
colorStops: { 0: '--success', 100: '--success' }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure i picked up on this before, these should be primary colour.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
primary
is gray in the PercentageBar
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the issue is that the bar is green when in progress, when it should be the primary colour. once complete we could change it to success / green, though it might be jarring as it'll flash up on screen. if the progress bar shows grey
for --primary
we should find another colour to show
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll try to change the PercentageBar component
Signed-off-by: Francesco Torchia <francesco.torchia@suse.com>
Signed-off-by: Francesco Torchia <francesco.torchia@suse.com>
Signed-off-by: Francesco Torchia <francesco.torchia@suse.com>
Signed-off-by: Francesco Torchia <francesco.torchia@suse.com>
Signed-off-by: Francesco Torchia <francesco.torchia@suse.com>
Signed-off-by: Francesco Torchia <francesco.torchia@suse.com>
Signed-off-by: Francesco Torchia <francesco.torchia@suse.com>
I did a couple of adjustments changing the name of |
Signed-off-by: Francesco Torchia <francesco.torchia@suse.com>
As discussed, lets test this in production. Can you create an issue? It could be that the dev world ui-backend-->epinio instance request takes a long time (far away from each other) ... and client-->ui-backend takes a short time (close to each other). In prod this will be the opposite. We've seen that the progress indicator moves incrementally for the client --> ui-backend, so we might be alright. |
Signed-off-by: Francesco Torchia <francesco.torchia@suse.com>
Thanks @richard-cox , I fixed trhe bar color. I think the last open point is to test the behavior (speed) of downloads, |
Fixes #223
Fixes #254
Blocked by #294
Technical Notes
jszip
version 3.10.1 significantly speed ups zip files generation and then download process.Layout