Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

R dependency and native pipe #24

Closed
sbfnk opened this issue Feb 5, 2025 · 2 comments · Fixed by #28
Closed

R dependency and native pipe #24

sbfnk opened this issue Feb 5, 2025 · 2 comments · Fixed by #28

Comments

@sbfnk
Copy link
Collaborator

sbfnk commented Feb 5, 2025

The native pipe |> is used in examples/vignettes. This requires R 4.1.0 but the DESCRIPTION only states a dependency on 4.0.0. Options are:

  1. update the dependency in the DESCRIPTION
  2. remove the pipe

I would prefer (1) but a counterargument is if we want to set the entry level low we might want to cater for people who never update their R installation.

Perhaps the thing to do is follow tidyverse which would mean we can move to requiring 4.1 at the next (imminent) R release and be safe with option (1) now.

@seabbs
Copy link
Collaborator

seabbs commented Feb 5, 2025

I would prefer 1. as well

@kaitejohnson
Copy link
Collaborator

Did not realise this! I think option 1 makes sense, though I am not super aware of the landscape of R versions among public health users ( I do remember in a previous project we had to lower it, but not below the native pipe I don't think)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants