-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue #4: Setup vignette #5
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
@seabbs A little stuck on the linting error (I see the warnings, one is for a global variable and the other falsely thinks a grep is a file path. But exit code 31 is about storage space so not sure. |
seabbs
reviewed
Jan 30, 2025
seabbs
reviewed
Jan 30, 2025
seabbs
reviewed
Jan 30, 2025
seabbs
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR closes #4.
Here we introduce the Getting Started vignette. We start by using
epinowcast
package data, which itself uses the truth data from the German hospitalization nowcast hub. It contains daily data indexed by reference date and report date.enw_preprocess_data()
is used, and we transform the output of thetriangle
to a matrix where the rows are the time points and the columns are the delays.We then use this reporting triangle to estimate the delay. The subsequent sections for applying the delay, estimating the uncertainty, and generating the nowcast are outlined.
Additional tests are required for internal functions, e.g.
handle_neg_values()
andvalidate_triangle()
.In future versions, we can modify the data we use for the vignette (e.g. another nice place to start might be from visit-level line list data as in https://github.com/kassteele/Nowcasting/blob/master/data/measles_NL_2013_2014.dat)
Checklist