Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed old import from class-transformer #56

Merged
merged 5 commits into from
Jan 20, 2021

Conversation

nicolaiort
Copy link
Contributor

Since class-transformer@0.3.2 the class-transformer/metadata/MetadataStorage got moved to class-transformer/types/MetadataStorage.
https://uiwjs.github.io/npm-unpkg/#/pkg/class-transformer@0.3.1
https://uiwjs.github.io/npm-unpkg/#/pkg/class-transformer@0.3.2

This import change should fix it.

We discovered this b/c our builds failed with this error:

node_modules/.pnpm/class-validator-jsonschema@2.1.0_3355ee6f645742ea3fc0591706016b64/node_modules/class-validator-jsonschema/build/options.d.ts(1,68): error TS2307: Cannot find module 'class-transformer/metadata/MetadataStorage' or its corresponding type declarations.
 ERROR  Command failed with exit code 2.
ERROR: Service '<<SERVICE>>' failed to build : The command '/bin/sh -c pnpm run build' returned a non-zero code: 1

Copy link
Owner

@epiphone epiphone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah that sucks... thanks for the fix though!

package.json Outdated Show resolved Hide resolved
As requested by @epiphone

Co-authored-by: Aleksi Pekkala <aleksipekkala@gmail.com>
@epiphone epiphone merged commit 162b23f into epiphone:master Jan 20, 2021
@epiphone
Copy link
Owner

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants