Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

configuration of the registry & the yarnrc file, added the explanatio… #1

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions .size-snapshot.json
Original file line number Diff line number Diff line change
Expand Up @@ -22,5 +22,29 @@
"code": 24005
}
}
},
"dist\\react-beautiful-dnd.js": {
"bundled": 366365,
"minified": 133985,
"gzipped": 39663
},
"dist\\react-beautiful-dnd.min.js": {
"bundled": 308204,
"minified": 108802,
"gzipped": 31552
},
"dist\\react-beautiful-dnd.esm.js": {
"bundled": 242094,
"minified": 125914,
"gzipped": 32817,
"treeshaked": {
"rollup": {
"code": 21121,
"import_statements": 503
},
"webpack": {
"code": 24005
}
}
}
}
Binary file added .yarn/install-state.gz
Binary file not shown.
16 changes: 16 additions & 0 deletions .yarnrc.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
compressionLevel: mixed

enableGlobalCache: true

nodeLinker: node-modules

npmScopes:
episerver:
npmAlwaysAuth: true
npmAuthToken: "${NPM_AUTH_TOKEN}"
npmRegistryServer: "https://npm.pkg.github.com/episerver"
optimizely:
npmAlwaysAuth: true
npmAuthIdent: "${ARTIFACTORY_USER}:${ARTIFACTORY_KEY}"
npmRegistryServer: "https://optimizely.jfrog.io/optimizely/api/npm/npm/"

45 changes: 45 additions & 0 deletions FORKED.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,45 @@
### Why this repo was forked?

the official repo from atlassian is here

https://github.com/atlassian/react-beautiful-dnd

the patched repo is here

https://github.com/casieber/react-beautiful-dnd

### PR to fix the issues between drag events & shadow Root is here and not merged yet in the official repo

https://github.com/atlassian/react-beautiful-dnd/pull/2319

Instead of using this fixed version as suggested in the comment
https://github.com/atlassian/react-beautiful-dnd/pull/2319#issuecomment-1269656861

and as the Axiom Team did here, adding a built lib inside axiom and using it in this user branch
https://jira.sso.episerver.net/browse/AX-969

https://github.com/optimizely/axiom/blob/user/hoshikitsunoda/AX-969-DragAndDrop-update-the-package-to-support-shadow-root/projects/axiom/src/libs/react-beautiful-dnd/index.js
and released "@optimizely/axiom": "^61.1.0-test.2",

with this package we were able to drag and drop correctly inside a Shadow root
https://jira.sso.episerver.net/browse/CMS-28999
https://github.com/episerver/content-edit-mfe/pull/48/files
using the <DragAndDrop> component exported from axiom

we probably should prefer to have a separate npm package, also because we want to work with Typescript
As suggested in the (last) comment here

https://github.com/atlassian/react-beautiful-dnd/pull/2319#issuecomment-1270765451

the first internal forked package is now published here in the episerver scope

https://github.com/episerver/forked-react-beautiful-dnd/pkgs/npm/forked-react-beautiful-dnd

## OPEN Questions

types ?
original package types are here:

@types/react-beautiful-dnd
this package refers to the atlassian official one,
do we need to fork also the types package in order to have it working properly in our forked and patche one
11 changes: 7 additions & 4 deletions package.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"name": "react-beautiful-dnd",
"name": "@episerver/forked-react-beautiful-dnd",
"version": "13.1.1",
"description": "Beautiful and accessible drag and drop for lists with React",
"author": "Alex Reardon <areardon@atlassian.com>",
Expand All @@ -17,10 +17,10 @@
],
"repository": {
"type": "git",
"url": "https://github.com/atlassian/react-beautiful-dnd.git"
"url": "git+https://github.com/episerver/forked-react-beautiful-dnd.git"
},
"bugs": {
"url": "https://github.com/atlassian/react-beautiful-dnd/issues"
"url": "https://github.com/episerver/forked-react-beautiful-dnd/issues"
},
"main": "dist/react-beautiful-dnd.cjs.js",
"module": "dist/react-beautiful-dnd.esm.js",
Expand Down Expand Up @@ -145,6 +145,9 @@
"wait-port": "0.2.9",
"webpack": "4.42.1"
},
"publishConfig": {
"registry": "https://npm.pkg.github.com/"
},
"peerDependencies": {
"react": "^16.8.5 || ^17.0.0 || ^18.0.0",
"react-dom": "^16.8.5 || ^17.0.0 || ^18.0.0"
Expand All @@ -153,4 +156,4 @@
"jest-junit": {
"output": "test-reports/junit/js-test-results.xml"
}
}
}
Binary file added package.tgz
Binary file not shown.
Loading