Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass functions as symbols rather than strings #27

Open
Bisaloo opened this issue Oct 9, 2023 · 1 comment
Open

Pass functions as symbols rather than strings #27

Bisaloo opened this issue Oct 9, 2023 · 1 comment
Assignees
Labels
bug Something isn't working discussion For package design discussions

Comments

@Bisaloo
Copy link
Member

Bisaloo commented Oct 9, 2023

The officially recommended practice to pass functions is to use symbols rather than strings that we convert to symbols:

fun.aggregate = lapply(summary_functions, as.symbol)

Passing functions as strings makes it difficult to do static analysis on code and impacts linting, seamless use of tools like the futureverse, etc.

@pratikunterwegs
Copy link
Collaborator

Thanks - {scenarios} functionality is under discussion, and this feature may or may not be continued, so I'll make this change when the package design is a bit more certain.

@pratikunterwegs pratikunterwegs self-assigned this Oct 10, 2023
@pratikunterwegs pratikunterwegs added bug Something isn't working discussion For package design discussions labels Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working discussion For package design discussions
Projects
None yet
Development

No branches or pull requests

2 participants