You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
At the moment, it seems that several arguments are passed from fit_seromodel() to rstan::sampling() directly, without any transformation.
Additionally, some rstan::sampling() are hardcoded, even though users might want to adjust them (e.g., number of chains).
The standard way to deal with this, allowing for maximum flexibility while keeping the fit_seromodel() function signature concise and clear, would be to pass argument to rstan::sampling() via ....
# TODO Add a warning because there are exceptions where a minimal amount of
# iterations is needed
if you really want to provide defaults but that's always' a difficult design choice. For example here, I definitely would not add a default for the seed, and would probably rely on rstan::sampling() existing defaults for chains, iter, thin, adapt_delta and max_treedepth()
At the moment, it seems that several arguments are passed from
fit_seromodel()
torstan::sampling()
directly, without any transformation.Additionally, some
rstan::sampling()
are hardcoded, even though users might want to adjust them (e.g., number of chains).The standard way to deal with this, allowing for maximum flexibility while keeping the
fit_seromodel()
function signature concise and clear, would be to pass argument torstan::sampling()
via...
.Additional reading on
...
: https://adv-r.hadley.nz/functions.html#fun-dot-dot-dotThe text was updated successfully, but these errors were encountered: