Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should the fit_method argument be maintained in probability_epidemic()? #89

Open
Bisaloo opened this issue Jan 29, 2024 · 0 comments
Open

Comments

@Bisaloo
Copy link
Member

Bisaloo commented Jan 29, 2024

Follow up from #77 (comment).

At the moment probability_epidemic() proposes two methods to compute the probability: via optim() and via a grid search.

We should investigate and clarify what the cases where one is better the other is, and document it.

If one option is always better than the other (more performant & more accurate), then it should be presented as the only option to:

  • avoid encouraging users to use invalid or deprecated methods
  • simplify the function usage
  • decrease the maintenance load
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant