Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set up continuous integration with Travis #20

Conversation

hydrosquall
Copy link
Contributor

Things to watch out for:

  • I have to run the Airflow1.9 test as a root user, because for some reason Airflow Webserver seems to be writing logs with a different user than it was doing in Airflow1.8.

Based on the travis log messages when running in non-detached mode, I believe the issue is that the user inside the container is unable to create new folders on the host machine. (example, search for permission denied).

I tried a couple different options to get around this issue, but this seemed like the cleanest.

Other possible extras:

  • Do we want to be stricter about what constitutes "valid" input besides returning 200 status code? (A strict text match doesn't make sense since the memory values would be a little different every time). I think there's room to improve, but that this could still help as a first-pass.

  • Does epoch8 have an organization Travis account? For now I'm running the CI jobs on my personal account, but you can use this same config file to tie the tests into your organization account: https://travis-ci.org/hydrosquall/airflow-exporter

@hydrosquall hydrosquall force-pushed the feature/set-up-continuous-integration-travis branch 2 times, most recently from 369ffa6 to 92aaa3a Compare October 16, 2018 05:48
@elephantum
Copy link
Contributor

@hydrosquall yesterday was a big day for bugs squashing, may be if you update to the latest master 1.9 will work for you.

@hydrosquall
Copy link
Contributor Author

@elephantum I think I am branched off the latest commit (c2af12e), but still getting this result.

I left in some commented-out code for workarounds I tried (mostly setting chown in either the dockerfile or bash script) but they don't seem to have had the desired effect.

Run as root user due to changes in python logging
@hydrosquall hydrosquall force-pushed the feature/set-up-continuous-integration-travis branch from 92aaa3a to f6bdaa7 Compare October 16, 2018 14:41
@elephantum
Copy link
Contributor

@hydrosquall I'll take a look this evening

@hydrosquall hydrosquall force-pushed the feature/set-up-continuous-integration-travis branch 4 times, most recently from 01dda23 to 69d2dc3 Compare October 17, 2018 22:41
@hydrosquall hydrosquall force-pushed the feature/set-up-continuous-integration-travis branch from 69d2dc3 to 8548a3d Compare October 18, 2018 00:58
@hydrosquall
Copy link
Contributor Author

hydrosquall commented Oct 18, 2018

@elephantum - I talked about this with my coworker @yegorski, who came up with an alternative to running as root. Instead, we use the user ID of the travis worker who is running the docker service, which feels slightly safer. I put that into the latest commit that has been pushed up.

@elephantum elephantum merged commit 8548a3d into epoch8:master Nov 19, 2018
hydrosquall added a commit to hydrosquall/airflow-exporter that referenced this pull request Nov 20, 2018
As a follow-up to epoch8#20, we can reveal the new users whether the master branch passes current tests.
@hydrosquall hydrosquall mentioned this pull request Nov 20, 2018
@hydrosquall hydrosquall deleted the feature/set-up-continuous-integration-travis branch December 13, 2018 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants