Refactor find historical bars #270
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 4, 2024 09:36
macanudo527
changed the title
macanudo527
force-pushed
the
pair_converters/refactor_find_historical_bars
branch
from
ce78526 to
1bd9a85
Compare
added 2 commits
December 5, 2024 09:05
macanudo527
force-pushed
the
pair_converters/refactor_find_historical_bars
branch
from
1bd9a85 to
6aaa9f8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This is a refactor of
find_historical_bars. I noticed while refactoring that pulling the bars from cache should be a guard clause at the top of the function. That caused a lot of revisions so I thought I would submit this early to make it easier to review.