Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Coinbase Advanced Pair Converter Plugin #271

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

macanudo527
Copy link
Collaborator

What?

This is a replacement for the historic crypto pair converter plugin that is no longer available. I made use of the Coinbase Advanced API with help from a code sample provided by @orientalperil here

Testing

I have not tested this personally with the real Coinbase server. I'll try to work up a short test to see if calls work as expected.

@macanudo527 macanudo527 self-assigned this Dec 13, 2024
@macanudo527 macanudo527 requested a review from eprbell December 13, 2024 00:40
@macanudo527 macanudo527 changed the title Implement Coinbase Advanced Implement Coinbase Advanced Pair Converter Plugin Dec 13, 2024
@macanudo527 macanudo527 force-pushed the pair_converters/implement_coinbase_advanced branch from b3516fd to 666a713 Compare December 13, 2024 02:03
@macanudo527 macanudo527 force-pushed the pair_converters/implement_coinbase_advanced branch from dff740f to 433902e Compare December 16, 2024 01:49
Copy link
Contributor

@orientalperil orientalperil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants