-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add note about mpdecimal
requirement on some Unix platforms
#108
Add note about mpdecimal
requirement on some Unix platforms
#108
Conversation
Potentially, another option is to include a check like this during some initialization routine: try:
from _decimal import *
except ImportError:
print(MPDECIMAL_NOT_AVAILABLE_WARNING)
sys.exit(-1) |
I think this is a good approach. It could go here: https://github.com/eprbell/rp2/blob/main/src/rp2/rp2_main.py#L70. The only changes needed are:
Then I think we no longer need the changes to the README files. |
333e6aa
to
4927365
Compare
updated! I also changed the import to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I just suggested a comment to describe the issue. Also I think it's fine to disable the import-outside-toplevel pylint warning on the line where it occurs.
4927365
to
6ea0bd3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good stuff!
#25 (comment)
mpdecimal
can't really be added as a dependency of RP2 since it's a system library rather than a Python package, but at least we can document it in the installation/setup instructions.