Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix calling mocked modules from expectation fun. #232

Merged
merged 1 commit into from
Aug 25, 2021

Conversation

pergu
Copy link
Contributor

@pergu pergu commented Aug 19, 2021

Before this change calling a mocked module from inside
an expectation fun, and then calling meck:passthrough/1
raises an exception. This happens because the current
call state is invalidated by the mocked function.

@eproxus
Copy link
Owner

eproxus commented Aug 24, 2021

Could you make an entry into CHANGELOG.md under ## [Unreleased] ### Fixed as well? E.g.

- Fix calling mocked modules from expectations fun [\#232](https://github.com/eproxus/meck/pull/232)

(I changed it to modules which I think is what you fixed, no?)

@pergu pergu changed the title Fix calling mocked functions from expectation fun. Fix calling mocked modules from expectation fun. Aug 24, 2021
Before this change calling a function in a mocked module
 from inside an expectation fun, and then calling
 meck:passthrough/1 raises an exception. This happens
  because the current function state is invalidated by
   the mocked function.
@pergu
Copy link
Contributor Author

pergu commented Aug 24, 2021

Alright, added the line to the changelog.

@eproxus eproxus merged commit b9a3e6e into eproxus:master Aug 25, 2021
@eproxus
Copy link
Owner

eproxus commented Aug 25, 2021

Thanks! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants