Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: Generating PT legs during mode choice + skipping routing during mode choice + update to Eqasim 1.5.0 (v2) #230

Merged
merged 12 commits into from
Apr 30, 2024
Merged

Feat: Generating PT legs during mode choice + skipping routing during mode choice + update to Eqasim 1.5.0 (v2) #230

merged 12 commits into from
Apr 30, 2024

Conversation

tkchouaki
Copy link
Collaborator

The first PR was having problems testing so I re-created it here
This PR proposes the following enhancements:

  • Generating a pt legs csv file during mode choice, allowing to directly analyze PT usage by the generated population
  • When using the mode choice, the population routing is skipped since routing already happens during the mode choice. This required to write the trip mode in the routingMode attribute when converting the trips csv file to a MATSim plans file in the matsim.scenario.population stage. For that the matsim/writers.py script was changed a bit.
  • Along the way the pipeline was updated to use Eqasim 1.5.0

@tkchouaki tkchouaki requested a review from sebhoerl April 24, 2024 15:26
@tkchouaki tkchouaki merged commit 00259df into develop Apr 30, 2024
2 checks passed
@tkchouaki tkchouaki deleted the pt_legs branch April 30, 2024 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebhoerl sebhoerl sebhoerl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tkchouaki @sebhoerl