Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat : option param to remove filtering for requesting dep in hts #249

Merged
merged 3 commits into from
Aug 20, 2024

Conversation

MarieMcLaurent
Copy link
Contributor

Link to issue #239

  • Boolean Parameter "filter_hts" to apply filtering on hts data; remove filtering by default with False
    This apply to all hts data, do you agree ?
  • Without filter 1 inconsistent activity types data on ENTD data appears => added fix_activity_types function to entd/cleaned file to resolve this error.

@sebhoerl
Copy link
Contributor

Thanks, looks good! Let's see if the tests pass, then we can merge it today.

Could you please add a note in the CHANGELOG for that as well?

I'll be on holidays starting later today, so maybe it will only be merged on 19 August, sorry in advance :)

@sebhoerl
Copy link
Contributor

sebhoerl commented Jul 25, 2024

The commits are failing, it looks like you haven't updated the unit tests yet. I think it will be sufficient if you simply set the option to True in the unit tests, then the same results as before should come out of them.

@MarieMcLaurent
Copy link
Contributor Author

MarieMcLaurent commented Jul 25, 2024

Yes the tests aren't update yet so with value as True could probably be enough to give same result as before. Add now to try this solution.

@sebhoerl sebhoerl merged commit f82e503 into eqasim-org:develop Aug 20, 2024
2 checks passed
@sebhoerl
Copy link
Contributor

Thanks! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants