Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docs): fix typos #1539

Closed
wants to merge 4 commits into from
Closed

chore(docs): fix typos #1539

wants to merge 4 commits into from

Conversation

omahs
Copy link
Contributor

@omahs omahs commented Nov 19, 2023

chore(docs): fix typos

@omahs omahs requested review from pierre-l and a team as code owners November 19, 2023 16:54
@sergey-melnychuk
Copy link
Contributor

Closing in favor of #1541

@omahs
Copy link
Contributor Author

omahs commented Nov 20, 2023

Hey @sergey-melnychuk you missed a few of my changes in the new PR, should I submit a new one with only these changes?

@sergey-melnychuk
Copy link
Contributor

@omahs , thank you for your pull request.

We can re-use this pull request if you want, but you'll still need to rebase the commits to avoid conflicts so submitting a new pull request might just be more practical. But it is up to you, please feel free to re-open this one or submit another one.

Since #1541 we have an automated check for typos, so I guess if the check passes but there are still false-positives we can also submit new entries to typos (e.g. crate-ci/typos#865 (comment)), then once such new entries are propagated, the build will fail until the typo is fixed, thus making the process of fixing typos automated instead of semi-manual and not only for a single project but for anyone using typos.

@omahs omahs mentioned this pull request Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants