Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove starknet_protocolVersion #495

Merged
merged 1 commit into from
Aug 3, 2022

Conversation

Mirko-von-Leipzig
Copy link
Contributor

@Mirko-von-Leipzig Mirko-von-Leipzig commented Aug 3, 2022

This will no longer form part of the RPC specification (PR) and as such we won't implement it.

As an aside I've now noticed that none of my PR's have added/updated the examples..

This will no longer form part of the RPC specification and as such we won't
implement it.
@Mirko-von-Leipzig Mirko-von-Leipzig requested a review from a team as a code owner August 3, 2022 13:57
Copy link
Contributor

@koivunej koivunej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point about the examples... I should try to remember to draft the more easily searched, maybe even CI-verifiable examples "form".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants