Fix validation of unassigned values

See https://datatracker.ietf.org/doc/html/rfc7643#section-2.5 Fixes tmilos#8
eqsgroup · Oct 25, 2024 · 9aecffc · 9aecffc
1 parent 2bc55de
commit 9aecffc
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 0 deletions.
diff --git a/src/Model/Schema/Attribute.php b/src/Model/Schema/Attribute.php
@@ -208,6 +208,11 @@ public function findAttribute($name)
 
     public function isValueValid($value)
     {
+        // https://datatracker.ietf.org/doc/html/rfc7643#section-2.5
+        if (!$this->required && in_array($value, [null, [], 'null'], true)) {
+            return true;
+        }
+
         switch ($this->type) {
             case ScimConstants::ATTRIBUTE_TYPE_STRING: return is_string($value);
             case ScimConstants::ATTRIBUTE_TYPE_BOOLEAN: return is_bool($value);

diff --git a/tests/Validator/SchemaValidatorTest.php b/tests/Validator/SchemaValidatorTest.php
@@ -53,6 +53,16 @@ public function test_list()
         $this->assertEmpty($this->validator->validate(['tags' => ['foo']], $schema)->getErrors());
     }
 
+    /**
+     * @testWith [{"nickName": null}, []]
+     *           [{"nickName": "null"}, []]
+     *           [{"userName": null}, ["[userName] Attribute has invalid value for type \"string\" [urn:ietf:params:scim:schemas:core:2.0:User]"]]
+     */
+    public function test_unassigned_value(array $data, array $expected)
+    {
+        $this->assertEquals($expected, $this->validator->validate($data, $this->schemaBuilder->getUser())->getErrorsAsStrings());
+    }
+
     public function test_enterprise_user_full()
     {
         $result = $this->validator->validate(