Fix analysis warnings

equalitie · Sep 7, 2023 · c626871 · c626871
1 parent c53c47b
commit c626871
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 4 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -66,7 +66,10 @@ jobs:
          flutter pub run ffigen
 
       - name: Analyze
-        run: flutter analyze
+        run: |
+          cd lib  && flutter analyze
+          cd test && flutter analyze
+          cd util && flutter analyze
 
       - name: Build OuiSync library for tests
         run: |

diff --git a/util/release.dart b/util/release.dart
@@ -21,7 +21,7 @@ Future<void> main(List<String> args) async {
   final commit = await getCommit();
 
   final versionName = stripBuild(version).canonicalizedVersion;
-  final buildName = commit != null ? '$versionName-$commit' : versionName;
+  final buildName = '$versionName-$commit';
 
   // Do a fresh build just in case (TODO: do we need this?)
   await cleanBuild();
@@ -364,9 +364,12 @@ Future<void> upload({
 }
 
 Future<File> collateAsset(
-    Directory outputDir, String outName, String suffix, File inputFile) async {
+  Directory outputDir,
+  String outName,
+  String suffix,
+  File inputFile,
+) async {
   final ext = extension(inputFile.path);
-  final basename = basenameWithoutExtension(inputFile.path);
   return await inputFile.copy(join(outputDir.path, '$outName-$suffix$ext'));
 }