Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update agent #53

Merged
merged 13 commits into from
Oct 3, 2024
Merged

Update agent #53

merged 13 commits into from
Oct 3, 2024

Conversation

tutkat
Copy link
Contributor

@tutkat tutkat commented Sep 19, 2024

https://equinixjira.atlassian.net/browse/CXF-102608

Updated agent to identify as fabric-sdk-java

# Conflicts:
#	equinix-openapi-fabric/src/main/java/com/equinix/openapi/fabric/ApiClient.java
Copy link
Contributor

@thogarty thogarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment. Needs update to process around versioning

Makefile Outdated Show resolved Hide resolved
@thogarty
Copy link
Contributor

@tutkat , you're mixing too many different changes together. Don't update the test files in this PR. Just focus on the User Agent update.

Open a second PR for testing updates and provide context as to why they're needed.

@tutkat
Copy link
Contributor Author

tutkat commented Oct 2, 2024

@thogarty corrected PR to make changes to change agent and versioning only based on another java repository which @ctreatma mentioned

Copy link
Contributor

@thogarty thogarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, @tutkat ! Thank you. Ship it.

@tutkat tutkat merged commit 119522a into main Oct 3, 2024
@tutkat tutkat deleted the updateAgent branch October 3, 2024 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants