This repository has been archived by the owner on Jun 28, 2024. It is now read-only.
Set user-agent and package version #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ctreatma
changed the title
displague
reviewed
Mar 22, 2023
displague
previously approved these changes
Mar 22, 2023
There was a problem hiding this comment.
If my comment about version.go being a template file looks too complex to investigate, let's convert it to an issue to revisit that concern.
That aside, this seems fine.
The openapi-generator has a parameter to specify the default UserAgent for the generated code so we don't have to duplicate the metal-go UA in client projects. This also sets the packageVersion parameter to match the version in the UserAgent, so that the docs display the correct version.
displague
approved these changes
Mar 22, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The openapi-generator has a parameter to specify the default UserAgent for the generated code so we don't have to duplicate the metal-go UA in client projects.
The generator also supports a package version parameter, but the value only gets written to the API.md doc, so client projects can't read the version. To work around this,
version.goparses the default User-Agent to extract the package version.Fixes #72