Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adopt metal-go #333

Closed
11 of 15 tasks
Tracked by #99
codinja1188 opened this issue Aug 16, 2023 · 1 comment · Fixed by #353 or #376
Closed
11 of 15 tasks
Tracked by #99

Adopt metal-go #333

codinja1188 opened this issue Aug 16, 2023 · 1 comment · Fixed by #353 or #376
Labels
enhancement New feature or request

Comments

@codinja1188
Copy link
Contributor

codinja1188 commented Aug 16, 2023 •
edited by displague
Loading

What is this issue?

This issue is to track the replacement packngo with metal-go for all interactions with the Equinix Metal API.
The Metal-go SDK is generated from the Equinix Metal API spec, and we will gradually replace all usage of packngo with Metal-go to streamline support.

Which issue(s) this PR fixes (optional, in fixes #(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

List of PRs

Replaces #270
@codinja1188 codinja1188 added the enhancement New feature or request label Aug 16, 2023
This was referenced Sep 5, 2023
Closed
Closed
@aayushrangwala aayushrangwala mentioned this issue Sep 27, 2023
Merged
@codinja1188
Copy link
Contributor Author

/assign @aayushrangwala

@aayushrangwala aayushrangwala mentioned this issue Sep 27, 2023
Merged
@aayushrangwala aayushrangwala mentioned this issue Nov 1, 2023
Merged
displague added a commit that referenced this issue Nov 9, 2023
@displague
chore: Migrate ports command from packngo to metal-go client (#355)
dc66c2d 
Issue Task as part of migrating metal-cli from packngo to metal-go
client, added the support of ports subcommand to use metal-go
Fixes: #333

Discussion:
As of metal-go 0.22.2 there is 1 issue which needs api support
- All the APIs such as `FindPortById`, `BondPort`, `DisbondPort`,
`CreatePortVlanAssignmentBatch` etc needs to support `Exclude([]string)`
parameter as well. It only supports `Includes([]string)`
@displague displague reopened this Nov 16, 2023
aayushrangwala added a commit to aayushrangwala/metal-cli that referenced this issue Nov 28, 2023
@aayushrangwala
chore: Migrate gateways command from packngo to metal-go client (equi…
1994e1e 
…nix#376)

Issue Task as part of migrating metal-cli from packngo to metal-go
client, added the support of gateways subcommand to use metal-go
Fixes: equinix#333

---------

Signed-off-by: Ayush Rangwala <ayush.rangwala@gmail.com>
ctreatma added a commit that referenced this issue Jan 24, 2024
@aayushrangwala @ctreatma
chore: Migrate Two FA from packngo to equinix-sdk-go client (#353)
9576704 
Issue Task as part of migrating metal-cli from packngo to metal-go
client, added the support of Two Fa to use metal-go
Fixes: #333

Discussion:
As of metal-go `0.22.2` there are 2 issues which needs api support
- Accepting `otp code` in the input for `Enable and Disable 2FA` is not
supported from metal-go
- Receiving an `otp` on two fa registered `app` is also not supported

---------

Signed-off-by: Ayush Rangwala <ayush.rangwala@gmail.com>
Co-authored-by: Charles Treatman <ctreatman@equinix.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
2 participants
@displague @codinja1188