Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump metal-go from v0.13.0 to v0.16.0 #320

Merged
merged 1 commit into from
Aug 3, 2023
Merged

Bump metal-go from v0.13.0 to v0.16.0 #320

merged 1 commit into from
Aug 3, 2023

Conversation

codinja1188
Copy link
Contributor

@codinja1188 codinja1188 commented Aug 3, 2023 •
edited by displague
Loading

Description:

Updated the Metal-go version and aligned some methods to version V0.16.0

Closes #317

@codinja1188 codinja1188 temporarily deployed to external August 3, 2023 11:51 — with GitHub Actions Inactive
@displague
Copy link
Member

displague commented Aug 3, 2023 •
edited
Loading

I assume Excludes was removed from the spec for these paths?

nit: I wonder with the semantic releases if we need to standardize on the titles for these kinds of PRs.
Today we have a variety of build(dep) and Bump ... PR titles and commit messages.

@displague displague mentioned this pull request Aug 3, 2023
Closed
ctreatma
ctreatma approved these changes Aug 3, 2023
View reviewed changes
Copy link
Contributor

@ctreatma ctreatma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Some parameters were removed from the official spec because they weren't actually supported in the API. We'll probably see more of this sort of thing as the spec continues to improve, so we'll have to consider whether we like that or not.

@ctreatma ctreatma merged commit 15e23b9 into equinix:main Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ctreatma ctreatma ctreatma approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@codinja1188 @displague @ctreatma