test: Improved device unit test cases and fixed issue #340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codinja1188
force-pushed
the
device-enhance
branch
from
89e6766
to
b04a49d
Compare
ctreatma
reviewed
Aug 31, 2023
test/helper/helper.go
Outdated
| @@ -74,6 +74,29 @@ func IsDeviceStateActive(deviceId string) (bool, error) { | |||
| return false, err | |||
| } | |||
|
|
|||
| func IsDeviceStateInActive(deviceId string) (bool, error) { | |||
There was a problem hiding this comment.
Rather than create a separate function, the existing helper could be updated to accept a state as an argument; that way we can avoid creating a new function if we find a third or fourth state we need to wait for.
ctreatma
reviewed
Aug 31, 2023
test/helper/helper.go
Outdated
| // Sleep for the specified interval | ||
| time.Sleep(retryInterval) | ||
| } | ||
| return false, err |
There was a problem hiding this comment.
Note that this is going to return a nil error; instead we should return an error that describes what happened. #339 shows how we could do that
codinja1188
force-pushed
the
device-enhance
branch
from
b04a49d
to
9e69ca3
Compare
cprivitere
changed the title
cprivitere
reviewed
Oct 9, 2023
cprivitere
reviewed
Oct 9, 2023
|
Was looking at this, seems like the state shouldn't be a string but instead some type defined in the generated API files. |
displague
reviewed
Dec 18, 2023
| @@ -125,8 +125,13 @@ func (c *Client) Create() *cobra.Command { | |||
| if billingCycle != "" { | |||
| facilityDeviceRequest.DeviceCreateInFacilityInput.SetBillingCycle(*validBillingCycle) | |||
| } | |||
| if alwaysPXE { | |||
| facilityDeviceRequest.DeviceCreateInFacilityInput.SetAlwaysPxe(alwaysPXE) | |||
| if alwaysPXE != "" { | |||
There was a problem hiding this comment.
displague
reviewed
Dec 18, 2023
|
Closing this since everything in here appears to have been addressed in other PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
We improved the device unit cases
Issue fixed?
#257