This repository has been archived by the owner on Aug 28, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 41
use Equinix Metal VMWare vSphere module #123
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the equinix/vsphere/metal module - Removes duplication of vsphere provisioning functionality from this module - Requires updating the module to TF 0.13 - Requires upgrading the Packet provider to Equinix Metal - Adds new input variables required by the vsphere module - Adds descriptions to outputs whose values previously included a description (making the value field concise and reusable) Fixes #113 Signed-off-by: Marques Johansson <mjohansson@equinix.com>
displague
commented
Mar 2, 2021
I should add |
Two provisioning errors on the first pass, both confined to the vsphere module:
I ran into the same problem when adding integration tests to that module: |
Signed-off-by: Marques Johansson <mjohansson@equinix.com>
Signed-off-by: Marques Johansson <mjohansson@equinix.com>
I've been running into some more full e2e test failures on the vsphere module, tracking that here: |
Signed-off-by: Marques Johansson <mjohansson@equinix.com>
Signed-off-by: Marques Johansson <mjohansson@equinix.com>
Signed-off-by: Marques Johansson <mjohansson@equinix.com>
Signed-off-by: Marques Johansson <mjohansson@equinix.com>
I'm missing GCP keys for the added integration test. |
Signed-off-by: Marques Johansson <mjohansson@equinix.com>
displague
force-pushed
the
use-vsphere-module
branch
from
March 29, 2021 20:59
7f49bd7
to
39267dd
Compare
Variable was previously replaced by relative_path_to_gcs_key Signed-off-by: Marques Johansson <mjohansson@equinix.com>
Signed-off-by: Marques Johansson <mjohansson@equinix.com>
Signed-off-by: Marques Johansson <mjohansson@equinix.com>
Signed-off-by: Marques Johansson <mjohansson@equinix.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the equinix/vsphere/metal module
module
description (making the value field concise and reusable)
Fixes #113
Part of #122
Part of #91
Relies heavily on the changes @c0dyhi11 made to the vSphere module in equinix/terraform-metal-vsphere#7 💪