Skip to content
This repository has been archived by the owner on Aug 28, 2024. It is now read-only.

use Equinix Metal VMWare vSphere module #123

Merged
merged 12 commits into from
Mar 29, 2021
Merged

Conversation

displague
Copy link
Member

@displague displague commented Mar 2, 2021

Use the equinix/vsphere/metal module

  • Removes duplication of vsphere provisioning functionality from this
    module
  • Requires updating the module to TF 0.13
  • Requires upgrading the Packet provider to Equinix Metal
  • Adds new input variables required by the vsphere module
  • Adds descriptions to outputs whose values previously included a
    description (making the value field concise and reusable)

Fixes #113
Part of #122
Part of #91

Relies heavily on the changes @c0dyhi11 made to the vSphere module in equinix/terraform-metal-vsphere#7 💪

Use the equinix/vsphere/metal module

- Removes duplication of vsphere provisioning functionality from this
  module
- Requires updating the module to TF 0.13
- Requires upgrading the Packet provider to Equinix Metal
- Adds new input variables required by the vsphere module
- Adds descriptions to outputs whose values previously included a
  description (making the value field concise and reusable)

Fixes #113

Signed-off-by: Marques Johansson <mjohansson@equinix.com>
variables.tf Outdated Show resolved Hide resolved
variables.tf Outdated Show resolved Hide resolved
versions.tf Outdated Show resolved Hide resolved
01-create-vsphere.tf Outdated Show resolved Hide resolved
@displague
Copy link
Member Author

I should add description to any variable that doesn't have one. This is mostly copy/paste from the vsphere module which added descriptions.

@displague
Copy link
Member Author

displague commented Mar 2, 2021

Two provisioning errors on the first pass, both confined to the vsphere module:

module.vsphere.null_resource.run_pre_reqs (remote-exec): mkdir: cannot create directory ‘/root/bootstrap/’: File exists
module.vsphere.null_resource.download_vcenter_iso (remote-exec): bash: /root/bootstrap/download_vcenter.sh: Not a directory

I ran into the same problem when adding integration tests to that module:
equinix/terraform-metal-vsphere#13

Signed-off-by: Marques Johansson <mjohansson@equinix.com>
Signed-off-by: Marques Johansson <mjohansson@equinix.com>
@displague
Copy link
Member Author

I've been running into some more full e2e test failures on the vsphere module, tracking that here:
equinix/terraform-metal-vsphere#19

Signed-off-by: Marques Johansson <mjohansson@equinix.com>
Signed-off-by: Marques Johansson <mjohansson@equinix.com>
Signed-off-by: Marques Johansson <mjohansson@equinix.com>
Signed-off-by: Marques Johansson <mjohansson@equinix.com>
@displague
Copy link
Member Author

I'm missing GCP keys for the added integration test.

Signed-off-by: Marques Johansson <mjohansson@equinix.com>
@displague displague force-pushed the use-vsphere-module branch from 7f49bd7 to 39267dd Compare March 29, 2021 20:59
Variable was previously replaced by relative_path_to_gcs_key

Signed-off-by: Marques Johansson <mjohansson@equinix.com>
Signed-off-by: Marques Johansson <mjohansson@equinix.com>
Signed-off-by: Marques Johansson <mjohansson@equinix.com>
Signed-off-by: Marques Johansson <mjohansson@equinix.com>
@displague displague merged commit 9fc771d into master Mar 29, 2021
@displague displague deleted the use-vsphere-module branch March 29, 2021 22:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Break out the vSphere portion into separate module
1 participant