Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add yopass guidelines #162

Merged
merged 1 commit into from
Oct 14, 2024
Merged

add yopass guidelines #162

merged 1 commit into from
Oct 14, 2024

Conversation

bra001
Copy link
Contributor

@bra001 bra001 commented Oct 11, 2024

No description provided.

@bra001 bra001 requested a review from aigelonic October 11, 2024 13:10
Copy link
Contributor

@aigelonic aigelonic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to name Yopass or just say that it is a service for secret sharing and currently this just happens to be yopass?
(as this comment/PR also is public, this is already "out there", though)

More an observation on if we should expose "implementation details" in a public site....

@bra001
Copy link
Contributor Author

bra001 commented Oct 11, 2024

I get your observation, but I personally think its fine. I considering the same with whether or not to add the link to the site, but concluded that it's acceptable risk. Could discuss on Mondays standup if you want

@aigelonic
Copy link
Contributor

I get your observation, but I personally think its fine. I considering the same with whether or not to add the link to the site, but concluded that it's acceptable risk. Could discuss on Mondays standup if you want

Yes, let's do that :-)

I think that having a guide/text here is fine, but that we do not necessarily need to say anything about Yopass; this just happens to be the current service we are utilizing...

@bra001 bra001 merged commit b427f3d into main Oct 14, 2024
@bra001 bra001 deleted the yopass-guidelines branch October 14, 2024 15:14
@bra001 bra001 restored the yopass-guidelines branch October 18, 2024 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants