Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ECLBASE is just using basename in runpath file #8522

Closed
2 of 13 tasks
oyvindeide opened this issue Aug 20, 2024 · 1 comment · Fixed by #8525
Closed
2 of 13 tasks

ECLBASE is just using basename in runpath file #8522

oyvindeide opened this issue Aug 20, 2024 · 1 comment · Fixed by #8525
Assignees
Labels

Comments

@oyvindeide
Copy link
Collaborator

What happened? (You can include a screenshot if it helps explain)

Previously the full ECLBASE was used in the runpath file when JOBNAME was not configured, however in #7350 that was changed to just basename. That means workflows parsing the runpath file to access simulation files are no longer looking in the right place.

What did you expect to happen?

Full ECLBASE in runpath file.

steps to reproduce

No response

Environment where bug has been observed

  • python 3.8
  • python 3.9
  • python 3.10
  • python 3.11
  • python 3.12
  • macosx
  • rhel7
  • rhel8
  • local queue
  • lsf queue
  • slurm queue
  • openPBS queue
  • used flag --enable-scheduler
@oyvindeide oyvindeide added the bug label Aug 20, 2024
@oyvindeide oyvindeide moved this to Todo in SCOUT Aug 20, 2024
@eivindjahren
Copy link
Contributor

As far as I know, the problem is that CSV_EXPORT2 expects ECLBASE to be the 3rd argument on each line of the runpath_list file. However, what has been put there is the jobname which has often been the eclbase. However, there were never any guarantee that jobname was the same as eclbase, and furthermore, on OpenPBS, "/" is not a valid character in a jobs name.

We could probably solve this by putting eclbase in the runpath_list if it exists, otherwise we put jobname.

@eivindjahren eivindjahren self-assigned this Aug 20, 2024
@eivindjahren eivindjahren moved this from Todo to In Progress in SCOUT Aug 20, 2024
@eivindjahren eivindjahren moved this from In Progress to Ready for Review in SCOUT Aug 20, 2024
@github-project-automation github-project-automation bot moved this from Ready for Review to Done in SCOUT Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants