Write eclbase to runpath_list if present #8525
Conversation
eivindjahren
added
the
release-notes:bug-fix
src/ert/runpaths.py
Outdated
| job_name_or_eclbase = self._substitution_list.substitute_real_iter( | ||
| self._jobname_format, realization, iteration | ||
| ) | ||
| runpath = self._substitution_list.substitute_real_iter( | ||
| self._runpath_format, realization, iteration | ||
| ) | ||
| if self._eclbase is not None: | ||
| job_name_or_eclbase = ( | ||
| self._substitution_list.substitute_real_iter( | ||
| self._eclbase, realization, iteration | ||
| ) | ||
| ) | ||
|
|
There was a problem hiding this comment.
eclbase_or_job_name = self._eclbase if self._eclbase else self._jobname_format
job_name_or_eclbase = self._substitution_list.substitute_real_iter(
eclbase_or_job_name, realization, iteration
)
Alternatively something like this? Less code-dedup?
There was a problem hiding this comment.
Did a similar thing
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8525 +/- ##
==========================================
+ Coverage 90.63% 90.67% +0.03%
==========================================
Files 342 342
Lines 20901 20943 +42
==========================================
+ Hits 18944 18990 +46
+ Misses 1957 1953 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| @@ -143,6 +143,7 @@ def load_from_forward_model( | |||
| runpath_format=self.config.model_config.runpath_format_string, | |||
| filename=str(self.config.runpath_file), | |||
| substitution_list=self.config.substitution_list, | |||
| eclbase=self.config.ensemble_config.eclbase, | |||
There was a problem hiding this comment.
Before this eclbase is not actually used anywhere, do we need to start using it, or can we do this some other way? Remove it here: 75961dc
There was a problem hiding this comment.
It is necessary as jobname/=eclbase.
|
Think we should also add some documentation about how this works |
Updated the docs. |
Issue
Resolves #8522
When applicable