Make lsf driver submit signal invalid instead of abort #6193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eivindjahren
force-pushed
the
fix_lsf_parse_handling
branch
3 times, most recently
from
38dc905
to
eab7ab6
Compare
eivindjahren
added
the
release-notes:skip
eivindjahren
changed the title
berland
reviewed
Sep 28, 2023
| @@ -28,31 +28,19 @@ void test_OK() { | |||
|
|
|||
| void test_file_does_not_exist() { | |||
| test_assert_int_equal(lsf_job_parse_bsub_stdout("bsub", "does/not/exist"), | |||
| 0); | |||
| -1); | |||
| } | |||
|
|
|||
| void parse_invalid(void *arg) { | |||
There was a problem hiding this comment.
This function can be deleted as well.
berland
reviewed
Sep 28, 2023
| @@ -71,13 +103,15 @@ def test_submit_attempt_is_initinally_zero(job_queue_node): | |||
| def test_when_submit_command_returns_invalid_output_then_submit_fails( | |||
There was a problem hiding this comment.
there is a typo on line 97 (initinally), fly-by-fix?
eivindjahren
force-pushed
the
fix_lsf_parse_handling
branch
2 times, most recently
from
73776d2
to
a2d53fc
Compare
Codecov Report
@@ Coverage Diff @@
## main #6193 +/- ##
==========================================
+ Coverage 82.64% 82.66% +0.02%
==========================================
Files 347 347
Lines 21249 21248 -1
Branches 834 833 -1
==========================================
+ Hits 17561 17565 +4
+ Misses 3390 3385 -5
Partials 298 298
... and 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
eivindjahren
force-pushed
the
fix_lsf_parse_handling
branch
from
a2d53fc
to
9a937d4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue where lsf driver submit fail would inconsistently abort instead of signal failure.
Pre review checklist
Ground Rules),
and changes to existing code have good test coverage.
Pre merge checklist