Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove usage of updatestep when calculating projection #6195

Merged
merged 1 commit into from
Oct 5, 2023

Conversation

dafeda
Copy link
Contributor

@dafeda dafeda commented Sep 28, 2023

Its cleaner and requires less work to use ensemble_config directly.

Pre review checklist

  • Read through the code changes carefully after finishing work
  • Make sure tests pass locally (after every commit!)
  • Prepare changes in small commits for more convenient review (optional)
  • PR title captures the intent of the changes, and is fitting for release notes.
  • Updated documentation
  • Ensured that unit tests are added for all new behavior (See
    Ground Rules),
    and changes to existing code have good test coverage.

Pre merge checklist

  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.

@dafeda dafeda self-assigned this Sep 28, 2023
@dafeda dafeda added maintenance Not a bug now but could be one day, repaying technical debt release-notes:skip If there should be no mention of this in release notes labels Sep 28, 2023
@codecov-commenter
Copy link

codecov-commenter commented Sep 28, 2023

Codecov Report

Merging #6195 (d378257) into main (14162a9) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #6195      +/-   ##
==========================================
+ Coverage   82.63%   82.65%   +0.01%     
==========================================
  Files         347      347              
  Lines       21244    21244              
  Branches      848      848              
==========================================
+ Hits        17556    17559       +3     
+ Misses       3390     3387       -3     
  Partials      298      298              
Files Coverage Δ
src/ert/analysis/_es_update.py 88.59% <100.00%> (ø)

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@dafeda dafeda force-pushed the simplify_projection branch 3 times, most recently from a89c819 to 304ec53 Compare October 2, 2023 11:33
@dafeda
Copy link
Contributor Author

dafeda commented Oct 4, 2023

Based on discussion with users that are disabling parameters for update and the fact that they use the same parameters to drive the models, I think this change is safe to make.

Its cleaner and requires less work to use ensemble_config directly.
@dafeda dafeda merged commit edef045 into equinor:main Oct 5, 2023
38 checks passed
@dafeda dafeda deleted the simplify_projection branch October 5, 2023 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Not a bug now but could be one day, repaying technical debt release-notes:skip If there should be no mention of this in release notes
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants