Get params from storage not from config #6200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dafeda
added
maintenance
oyvindeide
approved these changes
Sep 28, 2023
| prior_ens = snake_oil_storage.get_ensemble_by_name("default_0") | ||
| experiment = snake_oil_storage.get_experiment(prior_ens.experiment_id) | ||
| posterior_ens = snake_oil_storage.create_ensemble( | ||
| experiment, |
There was a problem hiding this comment.
Think you can just do: prior_ens.experiment_id here
There was a problem hiding this comment.
Same for the other instances as well
dafeda
force-pushed
the
use_storage_for_params
branch
4 times, most recently
from
3d2424b
to
5727a88
Compare
dafeda
force-pushed
the
use_storage_for_params
branch
from
5727a88
to
cb74949
Compare
Codecov Report
@@ Coverage Diff @@
## main #6200 +/- ##
==========================================
+ Coverage 82.64% 82.66% +0.01%
==========================================
Files 347 347
Lines 21249 21246 -3
Branches 834 834
==========================================
+ Hits 17561 17562 +1
+ Misses 3390 3387 -3
+ Partials 298 297 -1
... and 3 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre review checklist
Ground Rules),
and changes to existing code have good test coverage.
Pre merge checklist