Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor proper name formatting to reduce indents #6201

Merged
merged 1 commit into from
Sep 29, 2023

Conversation

dafeda
Copy link
Contributor

@dafeda dafeda commented Sep 28, 2023

Pre review checklist

  • Read through the code changes carefully after finishing work
  • Make sure tests pass locally (after every commit!)
  • Prepare changes in small commits for more convenient review (optional)
  • PR title captures the intent of the changes, and is fitting for release notes.
  • Updated documentation
  • Ensured that unit tests are added for all new behavior (See
    Ground Rules),
    and changes to existing code have good test coverage.

Pre merge checklist

  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.

@dafeda dafeda self-assigned this Sep 28, 2023
@dafeda dafeda added maintenance Not a bug now but could be one day, repaying technical debt release-notes:skip If there should be no mention of this in release notes labels Sep 28, 2023
@codecov-commenter
Copy link

codecov-commenter commented Sep 28, 2023

Codecov Report

Merging #6201 (c3802e7) into main (68ff10b) will decrease coverage by 0.01%.
Report is 1 commits behind head on main.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #6201      +/-   ##
==========================================
- Coverage   82.66%   82.66%   -0.01%     
==========================================
  Files         347      347              
  Lines       21248    21248              
  Branches      833      833              
==========================================
- Hits        17565    17564       -1     
- Misses       3385     3387       +2     
+ Partials      298      297       -1     
Files Coverage Δ
src/ert/validation/proper_name_argument.py 94.73% <100.00%> (ø)
src/ert/validation/proper_name_format_argument.py 94.73% <100.00%> (ø)

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@dafeda dafeda changed the title Refactor propr name formatting to reduce indents Refactor proper name formatting to reduce indents Sep 28, 2023
Copy link
Contributor

@kvashchuka kvashchuka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Copy link
Contributor

@eivindjahren eivindjahren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dafeda dafeda merged commit 9bc5ff5 into equinor:main Sep 29, 2023
40 checks passed
@dafeda dafeda deleted the valid_elif branch September 29, 2023 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Not a bug now but could be one day, repaying technical debt release-notes:skip If there should be no mention of this in release notes
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants