Compute cross-correlation matrices without matrix inversion #6339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Blunde1 I have checked and the tests with adaptive localization threshold 0.0 and 1.0 pass👍 |
dafeda
reviewed
Oct 17, 2023
dafeda
reviewed
Oct 17, 2023
oyvindeide
force-pushed
the
localization
branch
from
20cfcde
to
d80f169
Compare
8 tasks
tommyod
reviewed
Oct 18, 2023
src/ert/config/analysis_module.py
Outdated
| Section 2.3 - Localization in the CHOP problem | ||
| """ | ||
| default_threshold = 3 / math.sqrt(ensemble_size) | ||
| if user_defined_threshold == -1: |
There was a problem hiding this comment.
Please don't compare floats using ==.
In fact, I think using None is better here. More typical Python, more readable:
if user_defined_threshold is None:
return default_thresholdCome to think of it, I believe the (1) decision to use the default or user defined threshold and (2) retrieving the default threshold are two separate concerns. I think this is better:
threshold = # either a float in [0, 1], or None
self.threshold = correlation_threshold(ensemble_size) if threshold is None else thresholdIn other words, remove user_defined_threshold entirely. The decision is already taken before the function is called (by setting it to -1 / None), so no need to propagate the data down into the function.
There was a problem hiding this comment.
I agree with this.
Could you make an issue with this?
Blunde1
force-pushed
the
efficient-cross-correlation
branch
6 times, most recently
from
7055dcc
to
19072b4
Compare
Blunde1
force-pushed
the
efficient-cross-correlation
branch
from
19072b4
to
854436b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Resolves #6330
Approach
Use @tommyod approach #4243 (comment)