-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow users without equilibrium to run ert with FLOW simulator. #8324
Conversation
c2be884
to
55edaa2
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8324 +/- ##
==========================================
+ Coverage 90.60% 90.63% +0.03%
==========================================
Files 342 342
Lines 20898 20906 +8
==========================================
+ Hits 18935 18949 +14
+ Misses 1963 1957 -6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
src/ert/shared/share/ert/forward-models/res/script/ecl_config.py
Outdated
Show resolved
Hide resolved
src/ert/shared/share/ert/forward-models/res/script/ecl_config.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your patience with the questions. I think overall this looks good, could you also add some documentation so that this new behavior is described in the docs? (The current FLOW documentation does look a bit vague tbh, so if you feel like revising it a bit more that would be great). You could just write it into the Flow ForwardModelStepPlugin @ ert/shared/hook_implementations/forward_model_steps.py
src/ert/shared/share/ert/forward-models/res/script/ecl_config.py
Outdated
Show resolved
Hide resolved
55edaa2
to
0957bc2
Compare
I added a bit of information to We will need to expand on this documentation once and if we decide to support additional options. But currently without using a user-defined forward model job for flow ERT only supports the default options in a flow run. |
0957bc2
to
ffa6632
Compare
ffa6632
to
6806191
Compare
Could we also create an example in test-data/ for running with flow? (Similar to this, just a complete example people could use as a starting point) Then we could also run that example as part of our tests! |
6806191
to
286ed25
Compare
286ed25
to
4f97b05
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice 💯
Issue
Resolves #8223
Approach
Create
flow_config.yml
config file if it is not found in the env variables.When applicable