Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display experiment and ensemble name next to drag icon. #8339

Merged
merged 1 commit into from
Aug 1, 2024

Conversation

DanSava
Copy link
Contributor

@DanSava DanSava commented Jul 24, 2024

Issue
Resolves #8337

Approach
Also show full experiment and ensemble name in the element tool tip.

(Screenshot of new behavior in GUI if applicable)
image

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure tests pass locally (after every commit!)

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@DanSava DanSava self-assigned this Jul 24, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.99%. Comparing base (147c2e6) to head (41d025e).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8339      +/-   ##
==========================================
- Coverage   87.00%   86.99%   -0.02%     
==========================================
  Files         379      379              
  Lines       23609    23609              
  Branches      619      636      +17     
==========================================
- Hits        20541    20538       -3     
- Misses       2987     2998      +11     
+ Partials       81       73       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eivindjahren eivindjahren added the release-notes:improvement Automatically categorise as improvement in release notes label Aug 1, 2024
Copy link
Contributor

@eivindjahren eivindjahren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@DanSava DanSava merged commit e27780a into equinor:main Aug 1, 2024
38 checks passed
@DanSava DanSava deleted the plot_ens_name_fix branch August 1, 2024 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:improvement Automatically categorise as improvement in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Plot ensemble text is displayed under the drag symbol
3 participants