Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify openpbs job states #8347

Merged
merged 1 commit into from
Jul 25, 2024

Conversation

eivindjahren
Copy link
Contributor

@eivindjahren eivindjahren commented Jul 25, 2024

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure tests pass locally (after every commit!)

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@@ -30,7 +29,7 @@
logger = logging.getLogger(__name__)

_POLL_PERIOD = 2.0 # seconds
JobState = Literal[
JOB_STATES = [
Copy link
Contributor

@xjules xjules Jul 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issue is that we have the same pattern; ie. Literal states, in other drivers too.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was only used to iterate over in the openpbs driver and in the test so it didn't need to be a Literal, just a list. The other ones seem to be also used for typing.

Copy link
Contributor

@xjules xjules Jul 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to be fine then

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.86%. Comparing base (a51790c) to head (38220a4).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8347      +/-   ##
==========================================
+ Coverage   89.84%   89.86%   +0.02%     
==========================================
  Files         347      347              
  Lines       21138    21138              
==========================================
+ Hits        18991    18996       +5     
+ Misses       2147     2142       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@xjules xjules left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's ship it! 🚀

@eivindjahren eivindjahren merged commit 1fecbdb into equinor:main Jul 25, 2024
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants