-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify openpbs job states #8347
Simplify openpbs job states #8347
Conversation
@@ -30,7 +29,7 @@ | |||
logger = logging.getLogger(__name__) | |||
|
|||
_POLL_PERIOD = 2.0 # seconds | |||
JobState = Literal[ | |||
JOB_STATES = [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The issue is that we have the same pattern; ie. Literal states, in other drivers too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was only used to iterate over in the openpbs driver and in the test so it didn't need to be a Literal, just a list. The other ones seem to be also used for typing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems to be fine then
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8347 +/- ##
==========================================
+ Coverage 89.84% 89.86% +0.02%
==========================================
Files 347 347
Lines 21138 21138
==========================================
+ Hits 18991 18996 +5
+ Misses 2147 2142 -5 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's ship it! 🚀
When applicable