Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove exception and error message statefullness from run models #8375

Merged
merged 5 commits into from
Aug 5, 2024

Conversation

oyvindeide
Copy link
Collaborator

@oyvindeide oyvindeide commented Aug 2, 2024

Issue
Resolves #my_issue

Approach
Short description of the approach

(Screenshot of new behavior in GUI if applicable)

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure tests pass locally (after every commit!)

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@oyvindeide oyvindeide force-pushed the remove_redundant branch 3 times, most recently from 7ea8368 to 49eeb7f Compare August 2, 2024 13:13
Copy link
Collaborator

@sondreso sondreso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvement!

src/ert/run_models/base_run_model.py Outdated Show resolved Hide resolved
@oyvindeide oyvindeide changed the title Remove redundant function call Remove exception and error message statefullness from run models Aug 5, 2024
@oyvindeide oyvindeide added the release-notes:maintenance Automatically categorise as maintenance change in release notes label Aug 5, 2024
@oyvindeide oyvindeide self-assigned this Aug 5, 2024
@oyvindeide oyvindeide force-pushed the remove_redundant branch 2 times, most recently from 60e3c06 to 07f92df Compare August 5, 2024 08:31
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 94.44444% with 1 line in your changes missing coverage. Please review.

Project coverage is 90.87%. Comparing base (50a9869) to head (463a773).
Report is 2 commits behind head on main.

Files Patch % Lines
src/ert/run_models/base_run_model.py 93.75% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8375      +/-   ##
==========================================
- Coverage   90.88%   90.87%   -0.01%     
==========================================
  Files         347      347              
  Lines       21076    21064      -12     
==========================================
- Hits        19154    19142      -12     
  Misses       1922     1922              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@oyvindeide oyvindeide merged commit 110b466 into equinor:main Aug 5, 2024
37 checks passed
@oyvindeide oyvindeide deleted the remove_redundant branch August 5, 2024 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:maintenance Automatically categorise as maintenance change in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants