Improve documentation for NUM_CPU #8405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
berland
added
release-notes:misc
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8405 +/- ##
==========================================
- Coverage 90.88% 90.88% -0.01%
==========================================
Files 347 347
Lines 21078 21078
==========================================
- Hits 19157 19156 -1
- Misses 1921 1922 +1 ☔ View full report in Codecov by Sentry. |
jonathan-eq
reviewed
Aug 7, 2024
Comment on lines
272
to
273
| exclusiveness on the compute node. If set incorrectly, there is no guarantee | ||
| that the realization will fail. |
There was a problem hiding this comment.
Suggested change
| exclusiveness on the compute node. If set incorrectly, there is no guarantee | |
| that the realization will fail. | |
| exclusiveness on the compute node. If set incorrectly, there is no guarantee | |
| that the realization will run. |
Is this correct?
There was a problem hiding this comment.
Nope. You are lucky if you are able to fail your realization by specifying wrong cpu count. We had only a few failures when num_cpu was missing altogheter in the lsf_driver and hundreds of multi-cpu Eclipse runs were running and all of them said to the LSF system what "I only need 1 cpu".
jonathan-eq
requested changes
Aug 7, 2024
|
@sondreso any comment? |
sondreso
approved these changes
Aug 7, 2024
Don't mention any longer requirements for Torque, which are now deprecated.
berland
force-pushed
the
improve_num_cpu_docs
branch
from
87af89c
to
e1e0c43
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't mention any longer requirements for Torque, which are now deprecated.
Issue
Resolves #8403
Approach
✍🏻
When applicable