Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed a bug in std dev plot where color gradiant range was always 0 to 1 & two corner cells where always white #8408

Merged
merged 3 commits into from
Aug 7, 2024

Conversation

eivindjahren
Copy link
Contributor

@eivindjahren eivindjahren commented Aug 7, 2024

These images were produces by using the heat equation as forward model in ert.

image

Although it's hard to see whether the scaling is better or not, the new code seems to have fixed a strange where two corner cells are completely white. Also, the first row and column look strangely offset in the old code.

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure tests pass locally (after every commit!)

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 94.44444% with 1 line in your changes missing coverage. Please review.

Project coverage is 90.87%. Comparing base (f760d4c) to head (bb78072).

Files Patch % Lines
src/ert/gui/plottery/plots/std_dev.py 94.44% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #8408       +/-   ##
===========================================
+ Coverage   69.76%   90.87%   +21.10%     
===========================================
  Files         347      347               
  Lines       21066    21077       +11     
===========================================
+ Hits        14696    19153     +4457     
+ Misses       6370     1924     -4446     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eivindjahren eivindjahren marked this pull request as ready for review August 7, 2024 08:15
@eivindjahren eivindjahren added the release-notes:bug-fix Automatically categorise as bug fix in release notes label Aug 7, 2024
@eivindjahren eivindjahren self-assigned this Aug 7, 2024
@eivindjahren eivindjahren changed the title Update stddev snapshot Fixed a bug in std dev plot where color gradiant range was always 0 to 1 & two corner cells where always white Aug 7, 2024
@dafeda dafeda merged commit 4b48753 into equinor:main Aug 7, 2024
37 checks passed
@eivindjahren eivindjahren deleted the update_stddev_snapshot branch August 7, 2024 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:bug-fix Automatically categorise as bug fix in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants